Game Development Reference
You could just say “Call LoadLevel with level seventeen, high res and zero.�? A better read-
ing for inspection purposes would be to say “Call LoadLevel without checking the return
value. Pass the level information using a constant index of seventeen, the stored value of
highRes and a hard-coded zero.�? This second reading raises the following potential issues:
1. The return value of LoadLevel is not checked. Should it return a value to
indicate success, or a level number to verify the level you intended to load
did in fact get loaded?
2. Using a constant index for the level number may not be a good practice.
Should the level number come from a value passed to the routine that this
code belongs to or should the number 17 be referenced by a more descrip-
tive defined constant such as HAIKUDUNGEON in case something in the
future causes the level numbering to be re-ordered?
3. The value of 0 provides no explanation about its function or the parameter
it is being assigned to.
You can get similar results from reading test cases. Having another person try to liter-
ally understand your test steps word for word may not turn out as you intended.
The Tester does not have to be the person from the test team. This is a role where the
person questions things like whether the material being inspected is internally consis-
tent or consistent with any project documents it is based on. It is also good if the
Tester can foresee how this material will fit in with the rest of the project and how it
would potentially be tested.
A Recorder takes detailed notes about the issues raised in the inspection. The Recorder
is a second role that can be taken on by any of the four people involved. The Reader
is probably not the best choice for Recorder and you may find that it works best if the
Moderator accepts the Recorder role. The Moderator also helps keep the meeting on
track by limiting discussions to the material at hand.
Throughout the meeting the participants should not feel confined by their roles. They
need to become engaged in discussions of potential issues or how to interpret the
material. A successful inspection is one that invites the “Phantom Inspector.�? This is
neither an actual person nor a supernatural manifestation. Rather, it is a term to
explain the source of extra issues that are raised by the inspection team coming
together and feeding off of each other's roles.
Once the meeting has concluded, the Moderator determines whether any rework is
required before the material can be accepted. He continues to work with the Author to
follow up on issues until they are closed. An additional inspection may be necessary,
based on the volume or complexity of the changes.